Consolidate standard lints into a cargo config file #3386
Merged
+44
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In PR #3332, we added a Rust 2021 lint to Zebra's library crates. But we forgot to lint acceptance tests, examples, build scripts, and binaries. (These are technically separate crates.)
It would be much easier if we just had all of Zebra's standard lints in one place.
Specifications
We use cargo's hierarchical config structure to apply the lints to every crate:
https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure
This is similar to Embark Studio's lint configuration:
EmbarkStudios/rust-ecosystem#59
https://github.com/EmbarkStudios/rust-ecosystem/blob/main/lints.toml
Solution
zebra/.cargo/config.toml
Review
@dconnolly or anyone else can review this PR.
It should be merged before #3377 by @gustavovalverde, because it changes the paths that are used for lint CI.
Reviewer Checklist
Follow Up Work
Add more lints over time.