docs(transaction encoding): orchard fields #3507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3507 +/- ##
==========================================
+ Coverage 78.34% 78.45% +0.10%
==========================================
Files 267 273 +6
Lines 31526 31900 +374
==========================================
+ Hits 24698 25026 +328
- Misses 6828 6874 +46 |
22 tasks
28 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to make sure all the fields in the transaction tables of the protocol are documented in Zebra at serialization and deserialization.
This pull request deals with the sapling fields of transactions.
Closes #3424
Solution
Document orchard transaction fields.
Review
Anyone can review.
Reviewer Checklist
Follow Up Work
This is the last pull request of a series detailed here: #3222
No further work will be done by now in the subject if everything gets merged.