Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(ci): remove Windows support #3819

Merged
merged 2 commits into from
Mar 10, 2022
Merged

change(ci): remove Windows support #3819

merged 2 commits into from
Mar 10, 2022

Conversation

conradoplg
Copy link
Collaborator

Motivation

We can no longer support Windows, see #3704

Specifications

Designs

Solution

Remove Windows testing from CI

Review

Not super urgent, but this blocks #3799

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

@conradoplg conradoplg requested a review from a team as a code owner March 9, 2022 20:46
@conradoplg conradoplg requested review from teor2345 and removed request for a team March 9, 2022 20:46
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment would be if we can add a TODO to those comments, as it's visual and easier for follow up for things pending to solve in the future.

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conradoplg conradoplg requested a review from a team as a code owner March 9, 2022 23:31
@conradoplg
Copy link
Collaborator Author

My only comment would be if we can add a TODO to those comments, as it's visual and easier for follow up for things pending to solve in the future.

@gustavovalverde Added them in 5a511c8

Did you want to update these docs in this PR, or open a ticket or another PR?

@teor2345 Ah, thanks for the reminder. I changed them in 5a511c8. I didn't change the alpha-release-criteria.md since we're in beta now (maybe we should create one for beta?).

@teor2345
Copy link
Contributor

teor2345 commented Mar 9, 2022

I didn't change the alpha-release-criteria.md since we're in beta now (maybe we should create one for beta?).

Sounds like something for a ticket, or something we might do as part of:

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@teor2345
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2022

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor

I removed the Windows tests from the list of required jobs in GitHub settings.

@teor2345 teor2345 merged commit bbef390 into main Mar 10, 2022
@teor2345 teor2345 deleted the remove-windows-support branch March 10, 2022 00:50
@teor2345
Copy link
Contributor

This job needs a manual merge, because it changes Mergify rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants