-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(ci): remove Windows support #3819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment would be if we can add a TODO to those comments, as it's visual and easier for follow up for things pending to solve in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Did you want to update these docs in this PR, or open a ticket or another PR?
- https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/alpha-release-criteria.md
- https://github.com/ZcashFoundation/zebra/blob/main/README.md
- update supported platforms, add link to Windows issue in known issues
- https://github.com/ZcashFoundation/zebra/blob/main/book/src/user/requirements.md
@gustavovalverde Added them in 5a511c8
@teor2345 Ah, thanks for the reminder. I changed them in 5a511c8. I didn't change the |
Sounds like something for a ticket, or something we might do as part of:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great!
@Mergifyio refresh |
✅ Pull request refreshed |
I removed the Windows tests from the list of required jobs in GitHub settings. |
This job needs a manual merge, because it changes Mergify rules. |
Motivation
We can no longer support Windows, see #3704
Specifications
Designs
Solution
Remove Windows testing from CI
Review
Not super urgent, but this blocks #3799
Reviewer Checklist
Follow Up Work