2a. refactor(rpc): Add the ChainTip and Network to RpcImpl #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
3 tasks
teor2345
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3863 +/- ##
==========================================
+ Coverage 78.80% 78.85% +0.04%
==========================================
Files 296 296
Lines 33822 33833 +11
==========================================
+ Hits 26655 26679 +24
+ Misses 7167 7154 -13 |
3 tasks
teor2345
force-pushed
the
read-only-state-service-impl
branch
from
6c8b6db to
8870944
Compare
teor2345
changed the title
oxarbitrage
approved these changes
Mar 15, 2022
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to estimate the chain height for these RPCs:
This PR adds the fields, but doesn't implement the RPC.
Solution
Review
This PR could cause merge conflicts, so I'm marking it as a high priority.
It is based on PR #3847.
Reviewer Checklist
Follow Up Work
Implement #3143.