Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): make the full sync tests cache state at /zebrad-cache #4308

Merged
merged 2 commits into from
May 5, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 5, 2022

Motivation

This PR completes ticket #3545, by caching the state at the location required by the disk image workflow.

We mistakenly skipped part of this step in the ticket:

Create a test similar to sync_to_mandatory_checkpoint_* that syncs to a blockheight (NU5 activation?) and stops This exists as the full sync test to tip.

The test existed, but it cached its state in an ephemeral directory, rather than at a fixed path.

Solution

  • Use the same code and state path as the mandatory checkpoint state and full validation sync test
  • Move the tests so they are near the mandatory checkpoint tests

Review

@dconnolly can review this urgent PR, it blocks most of the lightwalletd test work.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-High 🔥 I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests lightwalletd any work associated with lightwalletd labels May 5, 2022
@teor2345 teor2345 requested a review from dconnolly May 5, 2022 07:58
@teor2345 teor2345 requested a review from a team as a code owner May 5, 2022 07:58
@teor2345 teor2345 self-assigned this May 5, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented May 5, 2022

@gustavovalverde I'm running a full sync at:
https://github.com/ZcashFoundation/zebra/actions/runs/2274405176

I tested it using:

RUST_BACKTRACE=full FULL_SYNC_MAINNET_TIMEOUT_MINUTES=1 cargo test --locked --release --features enable-sentry --test acceptance -- --nocapture --ignored full_sync_mainnet

and it uses the /zebrad-cache path on my machine.

That seems to be the default path for the full sync test in CI, so we should be good here.

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just confirmed the container is writing to the disk

@gustavovalverde gustavovalverde changed the title fix(test): make the full sync tests cache state at /zebrad-cache fix(test): make the full sync tests cache state at /zebrad-cache May 5, 2022
@gustavovalverde gustavovalverde merged commit d720ab0 into main May 5, 2022
@gustavovalverde gustavovalverde deleted the full-sync-cache-path branch May 5, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants