Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have a few fields of the Zebra config that are of type
Duration
. This are at the momentnetwork.crawl_new_peer_interval
andeviction_memory_time
.This fields are displayed as follows in the configuration file:
We want a more user friendly way for this entries of the config. Close #2847
Solution
Added humantime-serde to this fields as suggested in the ticket as it seems the best option. Now the fields with the problem will look as:
Which is a lot better. The change also allowed to move the debug fields to the end of the config section.
Review
I think anyone can review this.