-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log): Show the current network upgrade in progress logs #4694
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4694 +/- ##
==========================================
- Coverage 78.93% 78.90% -0.03%
==========================================
Files 304 306 +2
Lines 37506 37496 -10
==========================================
- Hits 29604 29585 -19
- Misses 7902 7911 +9 |
9f477c0
to
09b04f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great.
By reviewing this PR, I learned to compare only parts of different files against each other so that I can see what's changed, and what's just moved.
Yeah I find |
Motivation
It takes almost 6 hours for Zebra to sync all its checkpoints, so we need to be able to split CI jobs by network upgrade as well as checkpoint/full validation.
This is part of ticket #4661, it also includes a refactor I did as part of loading blocks from a file.
Solution
Features:
Fixes:
humantime
truncated to whole seconds, rather than raw seconds and microsecondsRefactors:
Review
This is a high priority because I need it for ticket #4661.
Reviewer Checklist