Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(checkpoints): update mainnet and testnet checkpoints #4708

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

Updating the checkpoints will speed up Zebra for users and in CI.

Review

This is a routine change, anyone can review it.

Reviewer Checklist

  • Existing tests pass

@teor2345 teor2345 added C-enhancement Category: This is an improvement P-Medium ⚡ I-slow Problems with performance or responsiveness labels Jun 28, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 28, 2022 04:17
@teor2345 teor2345 self-assigned this Jun 28, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 28, 2022 04:17
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #4708 (b19b8f7) into main (54efbe9) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4708      +/-   ##
==========================================
- Coverage   78.89%   78.80%   -0.09%     
==========================================
  Files         306      306              
  Lines       37498    37498              
==========================================
- Hits        29584    29552      -32     
- Misses       7914     7946      +32     

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to do this. should we do this with every release ?

mergify bot added a commit that referenced this pull request Jun 28, 2022
@mergify mergify bot merged commit 2103f36 into main Jun 28, 2022
@mergify mergify bot deleted the checkpoints-2022-06 branch June 28, 2022 16:08
@teor2345
Copy link
Contributor Author

Always good to do this. should we do this with every release ?

It doesn't really change performance that much, so every few months should be fine.
But if the large Orchard blocks continue, we might want to do it more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants