Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): make sure Rust tests actually run in deploy-gcp-tests.yml #4710

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 28, 2022

Motivation

It's easy to accidentally skip a test in CI, and not notice.
We want to check that we're actually running tests, and that they are succeeding.

Part of #2653.

Depends-On: #4704

Solution

In deploy-gcp-tests.yml:

  • before checking the exit status, check for "test result: 1 passed" in the logs
  • use a regex to allow multiple tests, even though we only currently run one
  • fail if the test logs don't show a success, or the test command returns a failing exit status

This PR does not check tests in any other workflows.

Review

This is a low priority, but it seemed easy to fix while I was in that file.

Reviewer Checklist

  • Existing tests pass

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ I-integration-fail Continuous integration fails, including build and test failures C-testing Category: These are tests labels Jun 28, 2022
@teor2345 teor2345 self-assigned this Jun 28, 2022
@teor2345 teor2345 requested a review from a team as a code owner June 28, 2022 04:44
@teor2345 teor2345 requested review from conradoplg and removed request for a team June 28, 2022 04:44
@teor2345 teor2345 changed the title fix(ci): make sure a Rust test actually ran in deploy-gcp-tests.yml fix(ci): make sure Rust tests actually run in deploy-gcp-tests.yml Jun 28, 2022
@teor2345 teor2345 marked this pull request as draft June 28, 2022 20:50
@teor2345 teor2345 requested review from gustavovalverde and removed request for conradoplg June 28, 2022 23:13
@teor2345 teor2345 force-pushed the check-tests-ran branch 2 times, most recently from c14ebc3 to 1621a43 Compare June 29, 2022 00:49
@teor2345 teor2345 marked this pull request as ready for review June 29, 2022 00:52
@teor2345 teor2345 force-pushed the ci-nu-split branch 2 times, most recently from 0a5734e to 74a9dda Compare June 30, 2022 02:07
Base automatically changed from ci-nu-split to main June 30, 2022 10:33
@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 10, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2022

update

✅ Branch has been successfully updated

mergify bot added a commit that referenced this pull request Aug 1, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Aug 3, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 3, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Aug 3, 2022
@mergify mergify bot merged commit dd273fe into main Aug 3, 2022
@mergify mergify bot deleted the check-tests-ran branch August 3, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-testing Category: These are tests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants