-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): make sure Rust tests actually run in deploy-gcp-tests.yml #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-Low ❄️
I-integration-fail
Continuous integration fails, including build and test failures
C-testing
Category: These are tests
labels
Jun 28, 2022
teor2345
changed the title
fix(ci): make sure a Rust test actually ran in deploy-gcp-tests.yml
fix(ci): make sure Rust tests actually run in deploy-gcp-tests.yml
Jun 28, 2022
teor2345
requested review from
gustavovalverde
and removed request for
conradoplg
June 28, 2022 23:13
teor2345
force-pushed
the
check-tests-ran
branch
2 times, most recently
from
June 29, 2022 00:49
c14ebc3
to
1621a43
Compare
teor2345
force-pushed
the
check-tests-ran
branch
from
June 29, 2022 02:43
1621a43
to
4ee13b4
Compare
teor2345
force-pushed
the
ci-nu-split
branch
2 times, most recently
from
June 30, 2022 02:07
0a5734e
to
74a9dda
Compare
3 tasks
teor2345
force-pushed
the
check-tests-ran
branch
from
June 30, 2022 02:19
4ee13b4
to
0c870cd
Compare
gustavovalverde
force-pushed
the
check-tests-ran
branch
from
June 30, 2022 14:02
4de5bfd
to
0c870cd
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
@Mergifyio update |
✅ Branch has been successfully updated |
@Mergifyio update |
✅ Branch has been successfully updated |
@Mergifyio update |
✅ Branch has been successfully updated |
dconnolly
reviewed
Aug 1, 2022
dconnolly
approved these changes
Aug 1, 2022
@Mergifyio refresh |
✅ Pull request refreshed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-bug
Category: This is a bug
C-testing
Category: These are tests
I-integration-fail
Continuous integration fails, including build and test failures
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's easy to accidentally skip a test in CI, and not notice.
We want to check that we're actually running tests, and that they are succeeding.
Part of #2653.
Depends-On: #4704
Solution
In
deploy-gcp-tests.yml
:This PR does not check tests in any other workflows.
Review
This is a low priority, but it seemed easy to fix while I was in that file.
Reviewer Checklist