fix(panic): Return errors instead of panics from Connection #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
|
We're giving network fixes a lower priority for now. This code isn't causing any problems in Zebra right now, we already merged smaller fixes for the hangs and panics. So feel free to finish off this task, or close it and move to something else. |
teor2345
changed the title
teor2345
reviewed
Aug 23, 2022
There was a problem hiding this comment.
@oxarbitrage did you want to close this PR?
It looks like it might take a bit more work to make sure all the errors are handled correctly, and get the tests passing again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Just positing for questions. Related to #4734
[TBA]
Solution
[TBA]
Review
[TBA]
Reviewer Checklist
Follow Up Work