Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(build): re-enable Rust beta tests in ubuntu #5024

Merged
merged 1 commit into from
Sep 2, 2022
Merged

ci(build): re-enable Rust beta tests in ubuntu #5024

merged 1 commit into from
Sep 2, 2022

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Sep 1, 2022 •
edited
Loading

Previous behavior:

As we disabled beta Rust tests in PR #4930, because the parameter
downloads were unstable with beta Rust, we're no longer testing it.

Expected behavior:

Re-enable beta rust tests in CI OSes

Solution:

Remove the parameter exluding beta Rust

Fixes #4929

Review

Anyone can review this

Reviewer Checklist

  • Beta Rust CI should pass

@gustavovalverde
ci(build): re-enable Rust beta tests in ubuntu
e7a0bbe 
Previous behavior:
As we disabled beta Rust tests in PR #4930, because the parameter
downloads were unstable with beta Rust, we're no longer testing it.

Expected behavior:
Re-enable beta rust tests in CI OSes

Solution:
Remove the parameter exluding beta Rust
@gustavovalverde gustavovalverde added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-testing Category: These are tests labels Sep 1, 2022
@gustavovalverde gustavovalverde self-assigned this Sep 1, 2022
@gustavovalverde gustavovalverde requested a review from a team as a code owner September 1, 2022 01:03
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team September 1, 2022 01:03
arya2
arya2 approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Sep 1, 2022
@mergify
Merge of #5024
ca11097
@mergify mergify bot mentioned this pull request Sep 1, 2022
Closed
@teor2345
Copy link
Contributor

teor2345 commented Sep 2, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2022

refresh

✅ Pull request refreshed

@teor2345
Copy link
Contributor

teor2345 commented Sep 2, 2022

This PR failed with an unrelated error on macOS:

---- server::tests::vectors::rpc_server_spawn_port_conflict stdout ----
note: panic did not contain expected string
panic message: "test task should exit with a RPC server panic: unexpected non-panic JoinError: JoinError::Cancelled(Id(293))",
expected substring: "Unable to start RPC server"

https://github.com/ZcashFoundation/zebra/runs/8145694716?check_suite_focus=true#step:13:6250

@teor2345 teor2345 mentioned this pull request Sep 2, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify
Merge of #5024
9d74b57
@mergify mergify bot mentioned this pull request Sep 2, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify
Merge of #5024
17d6bc0
@mergify mergify bot mentioned this pull request Sep 2, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify
Merge of #5024
066c4dc
@mergify mergify bot mentioned this pull request Sep 2, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify
Merge of #5024
36a2dfc
@mergify mergify bot mentioned this pull request Sep 2, 2022
Closed
mergify bot added a commit that referenced this pull request Sep 2, 2022
@mergify
Merge of #5024
97e8a6a
@mergify mergify bot mentioned this pull request Sep 2, 2022
Closed
@mergify mergify bot merged commit 422d20e into main Sep 2, 2022
@mergify mergify bot deleted the feat-add-beta-rust branch September 2, 2022 08:56
teor2345 added a commit that referenced this pull request Sep 6, 2022
@teor2345
Revert "ci(build): re-enable Rust beta tests in ubuntu (#5024)"
eab3be1 
This reverts commit 422d20e.
@teor2345 teor2345 mentioned this pull request Sep 6, 2022
Merged
mergify bot added a commit that referenced this pull request Sep 13, 2022
@teor2345 @mergify
Revert "ci(build): re-enable Rust beta tests in ubuntu (#5024)" (#5090)
579d6be 
This reverts commit 422d20e.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@teor2345 teor2345 mentioned this pull request Sep 19, 2022
Merged
36 tasks
gustavovalverde added a commit that referenced this pull request Oct 31, 2022
@gustavovalverde
Revert "Revert "ci(build): re-enable Rust beta tests in ubuntu (#5024)…
5eb8b31 
…" (#5090)"

This reverts commit 579d6be.
teor2345 pushed a commit that referenced this pull request Nov 1, 2022
@gustavovalverde
fix(build): restore Rust stable in builds and beta for CI (#5515)
bbbd56d 
* Revert "fix(ci): Build zebrad with Rust 1.63 to avoid Zcash parameter download hangs (#5251)"

This reverts commit 9cb6c55.

* Revert "Require Rust 1.63 in the README (#5359)"

This reverts commit ee0edef.

* Revert "Revert "ci(build): re-enable Rust beta tests in ubuntu (#5024)" (#5090)"

This reverts commit 579d6be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-testing Category: These are tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable beta Rust tests on Ubuntu
3 participants
@gustavovalverde @teor2345 @arya2