Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(testnet): look back up to 10,000 blocks on testnet for a legacy chain #5133

Merged
merged 7 commits into from
Sep 20, 2022
Merged

fix(testnet): look back up to 10,000 blocks on testnet for a legacy chain #5133

merged 7 commits into from
Sep 20, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 12, 2022 •
edited
Loading

Motivation

I'm seeing one of my testnet instances relaunch with a legacy chain error.

Solution

  • Increase the maximum number of legacy chain blocks to 10,000
  • Make the tests use 100 blocks as the limit

Review

Anyone can review this PR, it's not urgent.

Reviewer Checklist

  • CI passes

@teor2345 teor2345 added C-bug Category: This is a bug A-consensus Area: Consensus rule updates P-Medium ⚡ I-panic Zebra panics with an internal error message A-diagnostics Area: Diagnosing issues or monitoring performance A-state Area: State / database changes labels Sep 12, 2022
@teor2345 teor2345 self-assigned this Sep 12, 2022
@teor2345 teor2345 requested a review from a team as a code owner September 12, 2022 05:26
@teor2345 teor2345 requested review from upbqdn and removed request for a team September 12, 2022 05:26
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited
Loading

Codecov Report

Merging #5133 (9bc7a86) into main (b122052) will increase coverage by 0.09%.
The diff coverage is 90.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5133      +/-   ##
==========================================
+ Coverage   79.09%   79.19%   +0.09%     
==========================================
  Files         307      307              
  Lines       39218    39221       +3     
==========================================
+ Hits        31021    31061      +40     
+ Misses       8197     8160      -37

@teor2345
Copy link
Contributor Author

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2022

update

✅ Branch has been successfully updated

upbqdn
upbqdn previously approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@upbqdn upbqdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I left one small note.

zebra-state/src/service/check.rs Outdated Show resolved Hide resolved
@teor2345 teor2345 requested a review from upbqdn September 19, 2022 03:58
upbqdn
upbqdn previously approved these changes Sep 19, 2022
View reviewed changes
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 20, 2022 •
edited
Loading

I needed to merge use changes from main and this PR, then do a rustfmt using cargo fmt --all.

@teor2345 teor2345 requested a review from upbqdn September 20, 2022 06:02
@teor2345
Copy link
Contributor Author

Failed due to #5069:
https://github.com/ZcashFoundation/zebra/actions/runs/3087790499/jobs/4994029955

@teor2345
Copy link
Contributor Author

This is one I haven't seen before:

  • Internal error. Please try again or contact Google Support. (Code: '5E917363FAD65.6B58463.F6090D12')
  • Internal error. Please try again or contact Google Support. (Code: '5E917363FB573.6B58463.F6090D12')

https://github.com/ZcashFoundation/zebra/actions/runs/3087790499/jobs/4994831429#step:6:131

@mergify mergify bot merged commit 0db014d into main Sep 20, 2022
@mergify mergify bot deleted the legacy-chain-10k branch September 20, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees

@teor2345 teor2345

Labels
A-consensus Area: Consensus rule updates A-diagnostics Area: Diagnosing issues or monitoring performance A-state Area: State / database changes C-bug Category: This is a bug I-panic Zebra panics with an internal error message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @upbqdn