-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(ci): Fix incorrect docs about Docker build cache order #5190
Conversation
Looking at the logs, it seems like this tries the So this might just need a doc update, I'll try reversing the order. |
This order seems to work the way we want - checking the branch cache first. But annoyingly it doesn't say which cache it has used. I'll wait for Gustavo to confirm before merging. |
@Mergifyio update |
✅ Branch has been successfully updated |
Failed due to #5069 |
@Mergifyio update |
✅ Branch has been successfully updated |
Yesterday I used the wrong button here. I was trying to add this information with the previous action moby/moby#26839 (comment) |
Motivation
We want to use the branch build cache first, because the changes to a PR are usually small.
This is a comment-only PR.
Closes #5186.
API documentation
The order and failure behaviour of caches is undocumented:
https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#registry-cache
But it seems to be bottom to top, skip on failure.
(This is unusual, typically the order would be top to bottom.)
Review
This seems to be working in the most efficient way, but the docs are wrong.
Reviewer Checklist