-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(doc): Update README and release checklist for the release candidate #5314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I think we may need to finalise some details before we can publish though
Co-authored-by: Pili Guerra <mpguerra@users.noreply.github.com>
Co-authored-by: Pili Guerra <mpguerra@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
We want to change how we tag and release the release candidate.
Dependencies
The README and release checklist Docker instructions won't work until we fix:
Solution
docker run
commanddocker run
command from the README for testingFix #4953
Fix #4954
Review
I think Pili wanted to review this, but other engineers might want to as well.
Reviewer Checklist
Follow Up Work