fix(test): resolve a timing issue in mempool test #5347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix a mempool test that's failing occasionally.
The prior
mempool.dummy_call
s should also see the chain tip changes, and it's possible for the wait_for_tip_change call after the third block commit in this test to see the tip change from the first or second block commits.See #5322, closes #5301
Solution
Await
wait_for_tip_change
after every block commit.Review
Part of regular scheduled work.
Reviewer Checklist