Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): resolve a timing issue in mempool test #5347

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Oct 5, 2022

Motivation

To fix a mempool test that's failing occasionally.

The prior mempool.dummy_calls should also see the chain tip changes, and it's possible for the wait_for_tip_change call after the third block commit in this test to see the tip change from the first or second block commits.

See #5322, closes #5301

Solution

Await wait_for_tip_change after every block commit.

Review

Part of regular scheduled work.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@arya2 arya2 added C-bug Category: This is a bug A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-testing Category: These are tests A-state Area: State / database changes C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 5, 2022
@arya2 arya2 requested a review from teor2345 October 5, 2022 22:12
@arya2 arya2 requested a review from a team as a code owner October 5, 2022 22:12
@arya2 arya2 removed the S-needs-triage Status: A bug report needs triage label Oct 5, 2022
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #5347 (8208ea6) into main (9f6a1fd) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5347      +/-   ##
==========================================
+ Coverage   79.09%   79.12%   +0.02%     
==========================================
  Files         308      308              
  Lines       39560    39560              
==========================================
+ Hits        31291    31302      +11     
+ Misses       8269     8258      -11     

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Oct 6, 2022
@mergify mergify bot merged commit 7207f9d into main Oct 6, 2022
@mergify mergify bot deleted the mempool-cancel-mined-test-fix branch October 6, 2022 10:36
upbqdn pushed a commit that referenced this pull request Oct 11, 2022
@teor2345 teor2345 mentioned this pull request Oct 11, 2022
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes C-bug Category: This is a bug C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional failures in mempool_cancel_mined test
2 participants