fix(ci): Make "test all" log output shorter #5521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
github-actions
bot
added
the
C-trivial
|
@Mergifyio update |
✅ Branch has been successfully updated |
teor2345
commented
Nov 1, 2022
teor2345
commented
Nov 1, 2022
teor2345
commented
Nov 1, 2022
teor2345
commented
Nov 1, 2022
|
I lost the log snapshot but I restarted the CI jobs for 'disk full' messages on the OS jobs (linux and macos) |
dconnolly
approved these changes
Nov 1, 2022
dconnolly
suggested changes
Nov 1, 2022
Thanks, the options should be fixed now. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
It seems like @dconnolly is busy, @gustavovalverde would you mind reviewing this PR? |
|
Re-running the fail:
|
|
@Mergifyio update |
☑️ Nothing to do
|
dconnolly
previously approved these changes
Nov 4, 2022
|
I merged in the changes from PR #5549, then only applied --nocapture to the on-by-default tests. |
dconnolly
approved these changes
Nov 4, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes GitHub truncates the log output of "test all", which makes it hard to find the actual failure.
This impacts some release candidate PRs, and it happens pretty often, so I just went ahead and fixed it.
Part of #5518, but we still need to fix the full sync logs.
Solution
--nocapturefor "test all" in OS and Docker testsReview
This is something @gustavovalverde and I discussed today.
Reviewer Checklist
Follow Up Work