Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Disable the non_blocking_logger test on macOS #5522

Merged
merged 2 commits into from
Nov 2, 2022
Merged

fix(ci): Disable the non_blocking_logger test on macOS #5522

merged 2 commits into from
Nov 2, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 1, 2022

Motivation

The non_blocking_logger test fails occasionally on macOS.

Solution

macOS is not a supported test platform, so we can just disable this test.

Review

Anyone can review this PR.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-Medium ⚡ I-integration-fail Continuous integration fails, including build and test failures A-diagnostics Area: Diagnosing issues or monitoring performance labels Nov 1, 2022
@teor2345 teor2345 self-assigned this Nov 1, 2022
@teor2345 teor2345 requested a review from a team as a code owner November 1, 2022 00:37
@teor2345 teor2345 requested review from arya2 and removed request for a team November 1, 2022 00:37
@teor2345 teor2345 mentioned this pull request Nov 1, 2022
Merged
5 tasks
@codecov
Copy link

codecov bot commented Nov 1, 2022 •
edited
Loading

Codecov Report

Merging #5522 (d207620) into main (bbbd56d) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5522      +/-   ##
==========================================
+ Coverage   79.19%   79.24%   +0.05%     
==========================================
  Files         305      305              
  Lines       37870    37870              
==========================================
+ Hits        29991    30010      +19     
+ Misses       7879     7860      -19

@teor2345 teor2345 changed the title Disable the non_blocking_logger test on macOS fix(ci): Disable the non_blocking_logger test on macOS Nov 1, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Nov 1, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

update

✅ Branch has been successfully updated

@teor2345
Copy link
Contributor Author

teor2345 commented Nov 1, 2022

This is #5069:

kex_exchange_identification: read: Connection reset by peer

https://github.com/ZcashFoundation/zebra/actions/runs/3366621892/jobs/5583668776#step:6:109

gustavovalverde
gustavovalverde approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Nov 2, 2022
@mergify
Merge of #5522
702de0b
@mergify mergify bot mentioned this pull request Nov 2, 2022
Closed
@mergify mergify bot merged commit 7d90b3d into main Nov 2, 2022
@mergify mergify bot deleted the non-blocking-not-macos branch November 2, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@arya2 arya2 arya2 approved these changes

Assignees

@teor2345 teor2345

Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-rust Area: Updates to Rust code C-bug Category: This is a bug I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teor2345 @arya2 @gustavovalverde