Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gcp): add label to instances for cost and logs grouping #5693

Merged
merged 4 commits into from
Nov 24, 2022
Merged

feat(gcp): add label to instances for cost and logs grouping #5693

merged 4 commits into from
Nov 24, 2022

Conversation

gustavovalverde
Copy link
Member

Previous behavior:

We couldn't search GCP logs using the instance name if that instance was already deleted. And if we want to know how we're spending our budget its also difficult to know if specific tests or type of instances are the one responsible for a certain % of the costs

Fixes #5153
Fixes #5543

Expected behavior:

Be able to search logs using the test ID or at least the GitHub reference, and be able to group GCP costs by labels

Solution:

  • Add labels to instances

Review

Anyone can review this

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

@gustavovalverde
feat(gcp): add label to instances for cost and logs grouping
bb15997 
Previous behavior:
We couldn't search GCP logs using the instance name if that instance was
already deleted. And if we want to know how we're spending our budget its
also difficult to know if specific tests or type of instances are the one
responsible for a certain % of the costs

Fixes #5153
Fixses #5543

Expected behavior:
Be able to search logs using the test ID or at least the github reference,
and be able to group GCP costs by labels

Solution:
- Add labels to instances
@gustavovalverde gustavovalverde added A-infrastructure Area: Infrastructure changes P-Low ❄️ I-usability Zebra is hard to understand or use C-feature Category: New features labels Nov 22, 2022
@gustavovalverde gustavovalverde requested a review from a team as a code owner November 22, 2022 20:46
@gustavovalverde gustavovalverde self-assigned this Nov 22, 2022
@gustavovalverde gustavovalverde requested review from teor2345 and removed request for a team November 22, 2022 20:46
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Nov 22, 2022
teor2345
teor2345 suggested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the Zcash network to the metadata for each workflow?

We mostly run these on mainnet, but each workflow has a network parameter, and some work on testnet.

.github/workflows/zcashd-manual-deploy.yml Outdated Show resolved Hide resolved
@gustavovalverde
Copy link
Member Author

Bad value [Mainnet]: Only hyphens (-), underscores (_), **lowercase** characters 😮‍💨

gustavovalverde and others added 2 commits November 23, 2022 17:29
@teor2345 teor2345 mentioned this pull request Nov 23, 2022
Merged
5 tasks
@gustavovalverde
Copy link
Member Author

gustavovalverde commented Nov 23, 2022 •
edited
Loading

Let's leave the network label for later, as this will require some changes that weren't in this ticket scope.

Thanks for creating #5710 !!

@teor2345
Copy link
Contributor

Revert "chore: add Network as a label"

Let's do the network in PR #5710 then?

@gustavovalverde
Copy link
Member Author

Let's do the network in PR #5710 then?

Agree

teor2345
teor2345 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@teor2345 teor2345 mentioned this pull request Nov 23, 2022
Closed
mergify bot added a commit that referenced this pull request Nov 24, 2022
@mergify
Merge of #5693
3890402
@mergify mergify bot mentioned this pull request Nov 24, 2022
Closed
@mergify mergify bot merged commit c774541 into main Nov 24, 2022
@mergify mergify bot deleted the add-instance-labels branch November 24, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

Assignees

@gustavovalverde gustavovalverde

Labels
A-infrastructure Area: Infrastructure changes C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use
Projects
None yet
Milestone
No milestone
2 participants
@gustavovalverde @teor2345