fix(rust): Make Zebra build with the latest nightly Rust #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
teor2345
added
C-trivial
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5738 +/- ##
==========================================
+ Coverage 78.75% 78.79% +0.03%
==========================================
Files 306 306
Lines 38552 38563 +11
==========================================
+ Hits 30362 30384 +22
+ Misses 8190 8179 -11 |
|
Failed due to #5384 and a clippy warning about the workaround. |
dconnolly
reviewed
Nov 29, 2022
dconnolly
reviewed
Nov 29, 2022
dconnolly
approved these changes
Nov 29, 2022
|
Failed due to #5384 |
|
The underlying |
teor2345
added a commit
that referenced
this pull request
Feb 6, 2023
* Remove an unused async track_caller which will soon become a warning * Explicitly drop unused futures * Work around a compiler panic (ICE) with flat_map() rust-lang/rust#105044 * Remove a redundant into_iter() * allow(clippy::needless_collect)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra doesn't build on the latest nightly Rust due to a compiler bug:
rust-lang/rust#105044
Solution
It seems like it's going to be tricky to diagnose the bug, so I rewrote the code to avoid it.
I also dealt with some new clippy lints and compiler warnings.
Review
Anyone can review this fix. It's not urgent.
Reviewer Checklist