Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(consensus): Update mainnet and testnet checkpoints on 2022-12-01 #5754

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 1, 2022

Motivation

We need to update the checkpoints to speed up full syncs on the main branch.

This is based on the "settled network upgrade" consensus rule.

Designs

Follow the instructions for updating the checkpoints from zcashd.

Review

Updating the checkpoints is urgent because it might fix full sync timeouts on the main branch.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

We might need to add further jobs or increase the Rust test timeout if this isn't enough.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement P-Critical 🚑 I-slow Problems with performance or responsiveness labels Dec 1, 2022
@teor2345 teor2345 requested a review from a team as a code owner December 1, 2022 00:31
@teor2345 teor2345 self-assigned this Dec 1, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team December 1, 2022 00:31
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #5754 (7170b12) into main (26ff1b4) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5754   +/-   ##
=======================================
  Coverage   78.74%   78.74%           
=======================================
  Files         306      306           
  Lines       38687    38687           
=======================================
+ Hits        30463    30465    +2     
+ Misses       8224     8222    -2     

@teor2345
Copy link
Contributor Author

teor2345 commented Dec 1, 2022

Merge queue failed with ssh:

Timeout, server 34.135.163.112 not responding.

https://github.com/ZcashFoundation/zebra/actions/runs/3588904675/jobs/6041323885#step:8:297

@teor2345
Copy link
Contributor Author

teor2345 commented Dec 1, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Dec 1, 2022
@mergify mergify bot merged commit b3faa75 into main Dec 1, 2022
@mergify mergify bot deleted the checkpoints-2022-12-01 branch December 1, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants