Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect commands in the release checklist #7112

Closed
wants to merge 3 commits into from
Closed

Fix incorrect commands in the release checklist #7112

wants to merge 3 commits into from

Conversation

teor2345
Copy link
Contributor

Motivation

Some commands in the release checklist don't work.

Solution

Fix commands
Skip testing publishing of crates that have missing dependency errors

Review

This is a low priority documentation fix.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@teor2345 teor2345 added C-bug Category: This is a bug A-docs Area: Documentation P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-release Area: Zebra releases and release management labels Jun 30, 2023
@teor2345 teor2345 self-assigned this Jun 30, 2023
@teor2345 teor2345 requested a review from a team as a code owner June 30, 2023 01:50
@teor2345 teor2345 requested review from dconnolly and removed request for a team June 30, 2023 01:50
@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label Jul 2, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Jul 3, 2023

I'm going to open a post-release PR with a bunch of fixes instead of this PR.

@teor2345 teor2345 closed this Jul 3, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Jul 3, 2023

Replaced by #7128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly Awaiting requested review from dconnolly dconnolly is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@teor2345 teor2345

Labels
A-docs Area: Documentation A-release Area: Zebra releases and release management C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG do-not-merge Tells Mergify not to merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teor2345