Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix a new cargo fmt warning #7380

Closed
wants to merge 1 commit into from
Closed

fix: Fix a new cargo fmt warning #7380

wants to merge 1 commit into from

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Aug 24, 2023 •
edited
Loading

Motivation & Solution

This is the new change in rustfmt: rust-lang/rustfmt#5690

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@upbqdn upbqdn added C-bug Category: This is a bug A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles P-High 🔥 C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Aug 24, 2023
@upbqdn upbqdn self-assigned this Aug 24, 2023
@upbqdn upbqdn requested a review from a team as a code owner August 24, 2023 15:31
@upbqdn upbqdn requested review from teor2345 and removed request for a team August 24, 2023 15:31
@oxarbitrage oxarbitrage mentioned this pull request Aug 24, 2023
Merged
6 tasks
@gustavovalverde
Copy link
Member

gustavovalverde commented Aug 24, 2023 •
edited
Loading

Are we fixing fmt here and clippy in the other PR: #7381 ?

If that's the case, we might need to admin merge this PR or target #7831 to this one.

@oxarbitrage
Copy link
Contributor

#7381 includes this one so if that solution is ok we might want to merge that and close this.

teor2345
teor2345 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teor2345
Copy link
Contributor

Fixed in PR #7381.

@teor2345 teor2345 closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@teor2345 teor2345 teor2345 approved these changes

Assignees

@upbqdn upbqdn

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upbqdn @gustavovalverde @oxarbitrage @teor2345