-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(mining): Enable mining RPCs by default in production builds #7740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Failed due to #7744, I restarted CI. |
It seems like the fix in PR #7744 might be needed for CI to pass reliably on this PR. |
4 tasks
6 tasks
arya2
previously approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, may need a rebase.
arya2
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-Merge TODOs
Motivation
We want to enable mining by default in production builds.
Close #7361
Depends-On: #7744
Solution
Testing
This is a very verbose change, but all it does is pass the network from all the tests down to the base test config method, then set the miner address for mainnet or testnet there.
Review
This is a pretty straightforward change. It doesn't matter which release it goes in.
I'd like extra documentation cleanups to go in another PR or ticket, that's what we're doing with test cleanups.
Reviewer Checklist
Follow Up Work
These follow-up changes will be made in separate PRs: