-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
poc(scanner): add a populated state test for ZECpages viewing key #7916
Conversation
@arya2 can you push a commit to the branch ? |
So, we can merge this to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm not sure how the merge order works here, let's see if I can just approve it and Mergify works it out.
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that merge looks better
Motivation
As part of the proof of concept we want to make sure we can scan for the ZECpages viewing key even if we get no responses scanning the test data.
Close #7903
Solution
Add a test for the mentioned use case.
Review
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work