-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Allow to add keys to be scanned by the zebra-scan crate to config #7949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Adding zebra-scan
as a dependency in production zebrad
builds might be a blocker. Everything else is optional, I've tried to move as much work out of the MVP and onto the tracking issue as possible.
Co-authored-by: teor <teor@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the quick changes
CI failed due to #7898: So I'll restart it. |
Motivation
We want the user to add sapling keys to the config file so Zebra can scan the blockchain with them.
Close #7941
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Add a config type to the zebra-scan crate with a
sapling_keys_to_scan
field of typeIndexMap<String, u32>
where the string is the key and the number the birthday height.This field is used as:
The configuration is behind a
zebra-scan
rust feature so build should be done as follows to see the new section:Testing
This PR has been tested manually.
Review
This is a very basic version introducing the less amount of code possible, open to make changes.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work