Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(net): Document how outbound handshakes are rate-limited #7976

Merged
merged 1 commit into from
Nov 23, 2023
Merged

doc(net): Document how outbound handshakes are rate-limited #7976

merged 1 commit into from
Nov 23, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

This is a replacement for PR #7969, which made a duplicate fix for peer rate-limits. Instead, we should document those rate-limits in the caller.

Review

This is a minor documentation change that @arya2 asked for in a review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-concurrency Area: Async code, needs extra work to make it work properly. labels Nov 22, 2023
@teor2345 teor2345 requested a review from arya2 November 22, 2023 00:39
@teor2345 teor2345 self-assigned this Nov 22, 2023
@teor2345 teor2345 requested a review from a team as a code owner November 22, 2023 00:39
arya2
arya2 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mergify bot added a commit that referenced this pull request Nov 23, 2023
@mergify
Merge of #7976
855d141
@mergify mergify bot mentioned this pull request Nov 23, 2023
Closed
@mergify mergify bot merged commit ca062d0 into main Nov 23, 2023
103 checks passed
@mergify mergify bot deleted the peer-limit-doc branch November 23, 2023 21:59
@arya2 arya2 mentioned this pull request Nov 29, 2023
Merged
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@teor2345 teor2345

Labels
A-concurrency Area: Async code, needs extra work to make it work properly. A-docs Area: Documentation C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @arya2