-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(state): Expose ZebraDb methods that can create different kinds of databases #8002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-enhancement
Category: This is an improvement
P-Medium ⚡
A-state
Area: State / database changes
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
labels
Nov 27, 2023
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Nov 27, 2023
teor2345
commented
Nov 27, 2023
oxarbitrage
previously approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some unused code warnings this looks good, @teor2345 and I were in a meeting earlier today where they explained me the important parts of this PR, changes put ourselves one step closer to our needs of creating a database from the zebra-scan
crate.
…rade code out yet
teor2345
commented
Nov 28, 2023
oxarbitrage
approved these changes
Nov 28, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
A-state
Area: State / database changes
C-enhancement
Category: This is an improvement
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to be able to create a blockchain scanner results database as a completely separate database directory and instance. This is a rough draft of a first step, which allows different kinds of databases to be created using
ZebraDb::new()
.Close #8001
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Specifications
See the ticket for a rough design.
Complex Code or Requirements
There are a lot of code changes in this PR already, so I'd like to do the scanner database and its tests in another ticket.
Solution
Testing
Tests for new kinds of databases will be added when we add this database to the scanner.
The current state tests were updated and give good coverage.
Review
This PR blocks "Persistent storage of scanner results" in the MVP in #7728.
I'm looking for a review for a correct refactor. Missing functionality or additional refactors should go in the follow-up tickets #7926 and #7937.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
feat(zebra-db): Split low level database code inside
zebra-state
#7926:Create a
zebra-db
crate #7937