Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(scan): Refactor the user documentation for scanning #8124

Merged
merged 2 commits into from
Dec 29, 2023
Merged

change(scan): Refactor the user documentation for scanning #8124

merged 2 commits into from
Dec 29, 2023

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Dec 22, 2023 •
edited
Loading

Motivation & Solution

  • Refactor existing docs and fix some errors.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Is the documentation up to date?

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-docs Area: Documentation P-Low ❄️ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 22, 2023
@upbqdn upbqdn self-assigned this Dec 22, 2023
@upbqdn upbqdn requested a review from a team as a code owner December 22, 2023 00:05
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team December 22, 2023 00:05
@upbqdn upbqdn force-pushed the refactor-scanning-docs branch from 87c5845 to 57ac94c Compare December 22, 2023 00:07
@upbqdn upbqdn force-pushed the refactor-scanning-docs branch from 57ac94c to f5500f3 Compare December 22, 2023 00:14
oxarbitrage
oxarbitrage approved these changes Dec 29, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@mergify mergify bot merged commit f82c23b into main Dec 29, 2023
95 checks passed
@mergify mergify bot deleted the refactor-scanning-docs branch December 29, 2023 13:48
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@upbqdn upbqdn

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-docs Area: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upbqdn @oxarbitrage