Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch): Make bulk size the same for testnet and mainnet #8127

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

The bulk size for testnet is greater than mainnet which should synchronize the chain faster, however Elasticsearch has a limit of 100M per bulk. A stream of big blocks in the testnet can crash the node.

Close #7270

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

Make the testnet bulk size equal to the mainnet. This is 24 blocks per bulk.

Testing

I manually tested running the testnet, it syncing and adding records to the database as expected.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@oxarbitrage oxarbitrage added P-Low ❄️ I-panic Zebra panics with an internal error message C-feature Category: New features labels Dec 29, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner December 29, 2023 14:43
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Dec 29, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mergify bot added a commit that referenced this pull request Jan 1, 2024
@mergify mergify bot merged commit c0f88ed into main Jan 1, 2024
102 checks passed
@mergify mergify bot deleted the issue7270 branch January 1, 2024 23:21
@oxarbitrage oxarbitrage mentioned this pull request Jan 17, 2024
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-panic Zebra panics with an internal error message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid panics by always limiting elasticsearch bulk loads to 100MB
2 participants