Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(crate): Add a new zebra-grpc crate #8167

Merged
merged 5 commits into from
Jan 23, 2024
Merged

build(crate): Add a new zebra-grpc crate #8167

merged 5 commits into from
Jan 23, 2024

Conversation

oxarbitrage
Copy link
Contributor

Motivation

We want to create a new crate zebra-grpc and develop scanner related rpc queries there. Close #8161

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

This just add the basics used to create the crate placeholder. I think we might want to add more stuff as we need it but feel free to request now.

This PR makes the zebra-grpc crate depend on zebra-scan and tonic.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

This will unlock #8162 and #8164 and further work in the zebra-grpc crate.

@oxarbitrage oxarbitrage added A-rpc Area: Remote Procedure Call interfaces A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Jan 17, 2024
@oxarbitrage oxarbitrage requested a review from a team as a code owner January 17, 2024 20:33
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team January 17, 2024 20:33
@oxarbitrage oxarbitrage added the do-not-merge Tells Mergify not to merge this PR label Jan 17, 2024
@oxarbitrage oxarbitrage removed the do-not-merge Tells Mergify not to merge this PR label Jan 23, 2024
mergify bot added a commit that referenced this pull request Jan 23, 2024
@mergify mergify bot merged commit 001555b into main Jan 23, 2024
128 checks passed
@mergify mergify bot deleted the issue8161 branch January 23, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rpc Area: Remote Procedure Call interfaces
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Create new zebra-grpc crate
2 participants