-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remove): Temporally remove the internal miner functionality #8184
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I think we should skip adding the test config until we resolve this TODO if config_tests
passes without it.
test config changes were done because config test were NOT passing without them. |
Images were not build at CI. restarting all tests. https://github.com/ZcashFoundation/zebra/actions/runs/7625326629/job/20769382593?pr=8184#step:44:2 |
Motivation
Close #8180
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Review
Anyone can review, i marked as critical as we are in a merge freeze and it will not get merged otherwise.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
Create a hotfix including this removal of feature in the changelog. #8181