-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(scan): Implement Results
request
#8224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
A-blockchain-scanner
Area: Blockchain scanner of shielded transactions
P-Medium ⚡
labels
Feb 1, 2024
oxarbitrage
commented
Feb 1, 2024
arya2
reviewed
Feb 1, 2024
arya2
reviewed
Feb 1, 2024
arya2
previously approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just needs a blocking thread for the disk reads.
Co-authored-by: Arya <aryasolhi@gmail.com>
arya2
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to implement the
Results
request in order to later do theget_results
grpc.Close #8205
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Instead of just returning ids, this PR returns all data we have in a nested Tree. This data includes the corresponding key and height for each transaction hash found. A nested Tree structure is used to avoid repeating any data.
This version just returns all the results we have for the given keys. Height ranges or other tweaks were not included.
This request is less complex than others as no command needs to be sent to be scanner.
Testing
Test for the service is added, test for the
sapling_results
database function was not added as it is already tested bydeletes_keys_and_results_correctly
.Review
Anyone can review. I am open to suggestions to improve it.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
#8163