-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(scan): Implement SubscribeResults request for scan service #8253
Conversation
… executor and setting an appropriate start height
The acceptance test should pass now, the test was blocking the async executor with a blocking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, i made some small suggestions and some questions.
…keys are new keys
Motivation
We want to be able to subscribe to new scan results to stream to RPC clients.
Closes #8206.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
process_messages()
function to return a list of subscribed keys and their result senderssubscribed_keys
toscan_range()
tasksresult_sender
for a key and sends it new results if there are anyTesting
process_messages()
to check that it processesSubscribeResults
messages correctlyScanService
to see that it sends the message correctlyReview
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
scan_subscribe_results
test to CI #8259scan
grpc method #8256