Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update Debian from Bullseye to Bookworm #8273

Merged
merged 1 commit into from
Feb 14, 2024
Merged

ci: Update Debian from Bullseye to Bookworm #8273

merged 1 commit into from
Feb 14, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 14, 2024

Motivation

Close #8272. I think now is a good time to update Debian to Bookworm since it's causing issues with the current development instead of coming up with workarounds for Bullseye.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Specifications

Solution

  • Replace all occurrences of bullseye or Bullseye with bookworm or Bookworm.

Testing

Let's see if anything breaks in the CI.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ labels Feb 14, 2024
@upbqdn upbqdn self-assigned this Feb 14, 2024
@upbqdn upbqdn requested review from a team as code owners February 14, 2024 21:04
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team February 14, 2024 21:04
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 14, 2024
@upbqdn upbqdn requested review from gustavovalverde and removed request for oxarbitrage February 14, 2024 21:05
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 14, 2024
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify mergify bot merged commit 584bd23 into main Feb 14, 2024
154 checks passed
@mergify mergify bot deleted the update-debian branch February 14, 2024 23:02
@oxarbitrage
Copy link
Contributor

Sorry to be late, i think this change is ok but leaving the optional as it is will break the build in a lot of linux distributions.

For example i use Linux Mint 21.2 Cinnamon which is not that old and it is shipped with ibprotoc 3.12.4.

Upgrading does not seems to be that straightforward, i think we should use the alternative way to write the optionals as @arya2 suggested.

@upbqdn
Copy link
Member Author

upbqdn commented Feb 15, 2024

Ah, so I guess you can't compile Zebra now? Do you mean upgrading to Linux Mint 21.3 Virginia?

@oxarbitrage
Copy link
Contributor

I mean upgrading protoc alone. But still, i don't think we should force a version that current supported OSes do not have. I have the impression some users will give up right away if they have to upgrade their systems or the library.

In the other hand i think making the change to Bookworm for the CI as done in this PR is ok.

@oxarbitrage
Copy link
Contributor

I opened an issue for this at #8278

upbqdn added a commit that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The version of Protocol Buffers in the Docker file is too old
3 participants