-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update Debian from Bullseye to Bookworm #8273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sorry to be late, i think this change is ok but leaving the optional as it is will break the build in a lot of linux distributions. For example i use Linux Mint 21.2 Cinnamon which is not that old and it is shipped with Upgrading does not seems to be that straightforward, i think we should use the alternative way to write the optionals as @arya2 suggested. |
Ah, so I guess you can't compile Zebra now? Do you mean upgrading to Linux Mint 21.3 Virginia? |
I mean upgrading protoc alone. But still, i don't think we should force a version that current supported OSes do not have. I have the impression some users will give up right away if they have to upgrade their systems or the library. In the other hand i think making the change to Bookworm for the CI as done in this PR is ok. |
I opened an issue for this at #8278 |
Motivation
Close #8272. I think now is a good time to update Debian to Bookworm since it's causing issues with the current development instead of coming up with workarounds for Bullseye.
PR Author Checklist
Check before marking the PR as ready for review:
Specifications
protobuf-compiler
with Protocol Buffers v3.21: https://packages.debian.org/bookworm/protobuf-compiler, which supports optional fields in type definitions.Solution
bullseye
orBullseye
withbookworm
orBookworm
.Testing
Let's see if anything breaks in the CI.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.