Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional fields for Protocol Buffers older than v3.15.0 #8282

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Feb 19, 2024

Motivation

Close #8278.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Is the documentation up to date?

Solution

  • Enable the experimental_allow_proto3_optional flag for protoc.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-High 🔥 labels Feb 19, 2024
@upbqdn upbqdn requested a review from oxarbitrage February 19, 2024 10:57
@upbqdn upbqdn self-assigned this Feb 19, 2024
@upbqdn upbqdn requested a review from a team as a code owner February 19, 2024 10:57
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is good enough for me, thanks for the fix!

@mergify mergify bot merged commit 96c0d42 into main Feb 19, 2024
132 checks passed
@mergify mergify bot deleted the fix-protoc branch February 19, 2024 13:09
@upbqdn upbqdn mentioned this pull request Feb 23, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions P-High 🔥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an alternative to optional fields in protocol buffer files
2 participants