seed command
#83
Merged
seed command
#83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whaaat is going on with the Actions |
dconnolly
force-pushed
the
seeder-command
branch
from
57f05da to
5dd2717
Compare
hdevalence
reviewed
Oct 24, 2019
And more flushed out but incomplete
This may need some cleaning up, but this is the first iteration to appease the compiler.
dconnolly
force-pushed
the
seeder-command
branch
from
1a85732 to
9f94f83
Compare
Moved SeedService out of the command closure Command currently spawns a tokio task to DOS the seed service with `Request::GetPeers` every second. Pertains to #54
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
hdevalence
reviewed
Nov 12, 2019
Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
hdevalence
reviewed
Nov 12, 2019
| Network::Mainnet => Config::parse_peers(self.initial_mainnet_peers.clone()), | ||
| Network::Testnet => Config::parse_peers(self.initial_testnet_peers.clone()), | ||
| } | ||
| } |
There was a problem hiding this comment.
take-or-leave-it: since parse_peers is never used outside of initial_peers, it could be folded in as match self.network { ... } .iter().flat_map(...).flatten().collect(), and this saves an allocation by only doing one collect instead of two.
hdevalence
reviewed
Nov 12, 2019
hdevalence
reviewed
Nov 12, 2019
|
Yay, this is great! |
|
Not great: my ability to identify buttons |
…sitive response first, otherwise panic Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
Co-Authored-By: Henry de Valence <hdevalence@hdevalence.ca>
hdevalence
reviewed
Nov 12, 2019
This was referenced Nov 12, 2019
6 tasks
4 tasks
skyl
added a commit
to skyl/zebra
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some
Configupdates to populate default initial seeds based on the selected network (mainnet and testnet for now).