Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(docker): publish less tags in Docker Hub #8300

Merged
merged 2 commits into from
Feb 22, 2024
Merged

ref(docker): publish less tags in Docker Hub #8300

merged 2 commits into from
Feb 22, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

Fixes #7891

What are the most important goals of the ticket or PR?

  • Making our image tags less confusing.
  • Make our Docker Hub easier to navigate.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Change .experimental with -experimental
  • Just add the SHA on github pushes (to main or branches)
  • Remove extra versions tags using extra major and major.minor

Testing

Sadly, there's no way to test this until we make the release :/

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@gustavovalverde gustavovalverde added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement labels Feb 20, 2024
@gustavovalverde gustavovalverde self-assigned this Feb 20, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner February 20, 2024 22:21
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team February 20, 2024 22:21
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Feb 20, 2024
@upbqdn upbqdn added P-Critical 🚑 and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Feb 21, 2024
mergify bot added a commit that referenced this pull request Feb 21, 2024
@mergify mergify bot merged commit d631447 into main Feb 22, 2024
153 checks passed
@mergify mergify bot deleted the fix-docker-tags branch February 22, 2024 00:16
idky137 pushed a commit to idky137/zebra that referenced this pull request Feb 28, 2024
* ref(docker): publish less tags in Docker Hub

* fix: remove extra versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement P-Critical 🚑
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change(docker): Publish fewer Zebra docker tags, and standardise names
2 participants