-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove Zebra RFCs from CONTRIBUTING.md
#8304
Conversation
We have deprecated the RFC process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the RFC process is deprecated but i think we might want to replace it with something as:
Large changes:
When adding a large change or a series of pull requests into Zebra please make sure the whole context is written in a ticket and link each piece is linking to it. Sometimes, it might be useful to request a meeting or discuss in chat channels with the Zebra team to agree in the process to be taken.
I think this can be done in a separate PR. Right now I think it's important that people don't spend time on a process that we no longer follow :) |
CONTRIBUTING.md
We have deprecated the RFC process
We have deprecated the RFC process
Motivation
What are the most important goals of the ticket or PR?
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Specifications
Complex Code or Requirements
Solution
Testing
Review
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work