-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): OpenAPI spec #8342
Merged
feat(rpc): OpenAPI spec #8342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxarbitrage
added
A-docs
Area: Documentation
A-rpc
Area: Remote Procedure Call interfaces
P-Low ❄️
labels
Mar 11, 2024
This is lovely! ❤️ |
upbqdn
previously approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing. A great foundation for #8324.
Co-authored-by: Marek <mail@marek.onl>
upbqdn
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, thanks for the thorough comments describing the parsing process.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the hackaton sprint i went over developing a swagger API for zebra RPC methods. I tried different rust tools initially but they didn't went too well so i decided to create an utility that can extract the information needed from the documentation in the Rust code and create a specification with that.
The result of that is in this PR, it is a bit fragile and needs some more work but i think is a good start.
PR Author Checklist
Check before marking the PR as ready for review:
Solution
The generator will scrape data from the rust docs files to get the information needed to generate the open api spec. This code is a bit fragile and can be improved. This results in a binary called
openapi-generator
in thezebra-utils
crate.There is a lot of changes to method documentations to make them fit in the needed format, i tried to not make it very different than what we already had.
There are some defaults added to types so we can show example responses.
Testing
Manually. You can run the generator and paste the output into https://editor.swagger.io/
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work