Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): use Docker Build Cloud for image build #8374

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Conversation

gustavovalverde
Copy link
Member

@gustavovalverde gustavovalverde commented Mar 22, 2024

Motivation

We've been using extra large machines in GitHub (like our ubuntu-latest-xl) to be able to build our CI Docker images, as the build time is considerably large, but this has also increased our billing use above $1,000. For this reason we've considered moving this specific task to the new Docker Build Cloud service (https://www.docker.com/products/build-cloud/)

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?
For significant changes:
  • Is there a summary in the CHANGELOG?
  • Can these changes be split into multiple PRs?

If a checkbox isn't relevant to the PR, mark it as done.

Specifications

https://docs.docker.com/build/cloud/ci/

Solution

Configure the setup-buildx-action to use a remote buildx defined at https://build.docker.com/accounts/zfnd/builders

Testing

The image should get built, not slower than using our actual implementation

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Mar 22, 2024
@gustavovalverde gustavovalverde marked this pull request as ready for review March 22, 2024 08:59
@gustavovalverde gustavovalverde requested a review from a team as a code owner March 22, 2024 08:59
@gustavovalverde gustavovalverde requested review from arya2 and removed request for a team and arya2 March 22, 2024 08:59
@gustavovalverde gustavovalverde marked this pull request as draft March 22, 2024 10:00
@arya2 arya2 added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Apr 15, 2024
@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels May 3, 2024
@gustavovalverde gustavovalverde self-assigned this Jun 11, 2024
@gustavovalverde gustavovalverde added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-cost Zebra infrastructure costs labels Jun 11, 2024
@gustavovalverde gustavovalverde marked this pull request as ready for review June 11, 2024 21:10
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and seems to work, thank you!

.github/workflows/sub-build-docker-image.yml Show resolved Hide resolved
@gustavovalverde
Copy link
Member Author

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jun 12, 2024

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Jun 12, 2024
@mergify mergify bot merged commit 139e1c3 into main Jun 12, 2024
156 checks passed
@mergify mergify bot deleted the docker-build-cloud branch June 12, 2024 12:18
@upbqdn upbqdn mentioned this pull request Jun 28, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-cost Zebra infrastructure costs P-High 🔥
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants