-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): use Docker Build Cloud for image build #8374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Mar 22, 2024
gustavovalverde
force-pushed
the
docker-build-cloud
branch
from
March 22, 2024 08:48
87742bc
to
d85220d
Compare
gustavovalverde
requested review from
arya2
and removed request for
a team and
arya2
March 22, 2024 08:59
gustavovalverde
force-pushed
the
docker-build-cloud
branch
from
March 22, 2024 10:14
d5b93b7
to
773b0b5
Compare
arya2
added
do-not-merge
Tells Mergify not to merge this PR
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
Apr 15, 2024
oxarbitrage
added
do-not-merge
Tells Mergify not to merge this PR
and removed
do-not-merge
Tells Mergify not to merge this PR
labels
May 3, 2024
gustavovalverde
force-pushed
the
docker-build-cloud
branch
from
May 14, 2024 21:57
5f835a1
to
90a38b9
Compare
gustavovalverde
force-pushed
the
docker-build-cloud
branch
from
May 23, 2024 15:29
90a38b9
to
2e8bfcc
Compare
9 tasks
gustavovalverde
added
A-infrastructure
Area: Infrastructure changes
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-enhancement
Category: This is an improvement
I-cost
Zebra infrastructure costs
labels
Jun 11, 2024
arya2
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to work, thank you!
@Mergifyio refresh |
✅ Pull request refreshed |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-devops
Area: Pipelines, CI/CD and Dockerfiles
A-infrastructure
Area: Infrastructure changes
C-enhancement
Category: This is an improvement
C-feature
Category: New features
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-cost
Zebra infrastructure costs
P-High 🔥
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We've been using extra large machines in GitHub (like our
ubuntu-latest-xl
) to be able to build our CI Docker images, as the build time is considerably large, but this has also increased our billing use above $1,000. For this reason we've considered moving this specific task to the new Docker Build Cloud service (https://www.docker.com/products/build-cloud/)PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Specifications
https://docs.docker.com/build/cloud/ci/
Solution
Configure the
setup-buildx-action
to use a remotebuildx
defined at https://build.docker.com/accounts/zfnd/buildersTesting
The image should get built, not slower than using our actual implementation
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.