-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(rpc): Add block times to verbose output of getblock
RPC method
#8384
Conversation
…1 (it's already included with verbosity = 0 but this makes it easier to use).
We may want to get the full block data from the state service for Or we may not need to match zcashd's output exactly. Update: If we do want to match zcashd's output, we could:
|
It seems like the scope for this PR is possibly expanding. Should we create an issue for all of the things we may want to do in order to support lightwalletd and potentially also match zcashd behaviour? |
Motivation
This field is provided in zcashd and was asked about on Discord.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
BlockHeader
state requests/responses (there were alreadyFindBlockHeaders
requests/responses, this one is simpler)getblock()
RPC methodtime
field to the verbose return value from thegetblock()
RPCTesting
Update the existing snapshot and vectors tests to include block time.
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work
getblock
RPC's verbose output