-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(zcash_script): Bump zcash script v0.1.15 and restore Windows support #8393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may be able to re-enable the rejection_restores_internal_state_genesis()
test.
The logs suggest that the rpc_server_spawn_single_thread
test is redundant on Windows, so I think it's fine to skip it, or to skip the multi-thread version of the test, either should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Motivation
Updates
zcash_script
to0.1.15
andzcash_primitives
to0.13.0
.PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
Update zcash_script, restore windows support to CI and disable tests were needed.
Testing
Windows CI and @arya2 made some local checks in windows.
Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work