-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(consensus): Add slow_start_{interval/shift}
fields to testnet::Parameters
#8477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
A-consensus
Area: Consensus rule updates
C-cleanup
Category: This is a cleanup
NU-6
Network Upgrade: NU6 specific tasks
P-Medium ⚡
labels
Apr 30, 2024
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Apr 30, 2024
@arya, this PR needs a manual conflict resolution. |
5 tasks
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 16:13
6fa0e51
to
5ea89e3
Compare
arya2
added
do-not-merge
Tells Mergify not to merge this PR
P-Medium ⚡
and removed
P-Critical 🚑
labels
May 3, 2024
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 16:45
5ea89e3
to
9bde989
Compare
- Moves SLOW_START_INTERVAL/SLOW_START_SHIFT constants to zebra-chain
arya2
force-pushed
the
params-slow-start-interval
branch
from
May 3, 2024 18:08
9bde989
to
5b33680
Compare
upbqdn
previously approved these changes
May 6, 2024
Co-authored-by: Marek <mail@marek.onl>
oxarbitrage
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Area: Consensus rule updates
C-cleanup
Category: This is a cleanup
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
NU-6
Network Upgrade: NU6 specific tasks
P-Medium ⚡
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds fields to
testnet::Parameters
and is cleanup for #8475.Part of #7119.
Depends-On: #8475.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
slow_start_interval
andslow_start_shift
fields totestnet::Parameters
SLOW_START_INTERVAL
andSLOW_START_SHIFT
constants to zebra-chainTesting
The
new_regtest()
method should be tested byregtest_submit_blocks()
, some of the rest should be covered by existing tests, there may be a minor gap in coverage considering a mistake was made in the previous PR.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.