fix(consensus): Update median_timespan()
method to align with zcashd implementation
#8491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a minor mistake in the
median_timespan()
method below block height 28. The bug does not affect checkpoint validation, and does not affect Mainnet or the default Testnet because Zebra requires checkpoint verification until well past block height 28 for those networks.https://github.com/zcash/zcash/blob/master/src/pow.cpp#L47-L84
Depends-On: #8475.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Specifications
Section 7.7.3, page 132 of the specification
Solution
Use the MedianTime of the genesis block as the
older_median
if there are fewer than PoWAveragingWindow blocks in the relevant chain.Other changes:
Review
Anyone can review, @upbqdn may be interested.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.