Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Add missing jobs to workflows patch #8578

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(ci): Add missing jobs to workflows patch #8578

merged 1 commit into from
Jun 4, 2024

Conversation

gustavovalverde
Copy link
Member

Motivation

Some jobs has been recently added, but the workflows patch were not updated, causing some PRs to be halted and not being able to merge them as this jobs were not triggered by the changed files.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

  • Add missing jobs to patch workflows

Testing

  • This PR should not show pending tests

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑 labels Jun 4, 2024
@gustavovalverde gustavovalverde self-assigned this Jun 4, 2024
@gustavovalverde gustavovalverde requested a review from a team as a code owner June 4, 2024 15:36
@gustavovalverde gustavovalverde requested review from oxarbitrage and removed request for a team June 4, 2024 15:36
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 4, 2024
@mergify mergify bot merged commit f2ab327 into main Jun 4, 2024
101 checks passed
@mergify mergify bot deleted the fix-ci-edge-case branch June 4, 2024 16:06
@gustavovalverde gustavovalverde mentioned this pull request Jun 5, 2024
Closed
@mpguerra mpguerra linked an issue Jun 6, 2024 that may be closed by this pull request
Windows tests get stuck on pull requests updating github action files #8496
Closed
@upbqdn upbqdn mentioned this pull request Jun 28, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

@oxarbitrage oxarbitrage Awaiting requested review from oxarbitrage oxarbitrage is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures P-Critical 🚑
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows tests get stuck on pull requests updating github action files
2 participants
@gustavovalverde @upbqdn