-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: General conditional compilation attributes #8602
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
extra-reviews
This PR needs at least 2 reviews to merge
label
Jun 11, 2024
See https://blog.rust-lang.org/2024/05/06/check-cfg.html The conditional compilation flags for tor were superfluous as we can make do fine with using only features.
github-actions
bot
added
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Jun 11, 2024
upbqdn
changed the title
fix(network): Remove general conditional compilation attributes
fix: General conditional compilation attributes
Jun 11, 2024
arya2
previously approved these changes
Jun 11, 2024
upbqdn
removed
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 11, 2024
oxarbitrage
approved these changes
Jun 11, 2024
7 tasks
This PR should merge as it is only failing in Windows. |
@Mergifyio refresh |
✅ Pull request refreshed |
arya2
approved these changes
Jun 12, 2024
It was the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See https://blog.rust-lang.org/2024/05/06/check-cfg.html
This change in
beta
causes CI errors in docs compilation.PR Author Checklist
Check before marking the PR as ready for review:
Solution
[cfg(tor)]
conditional compilation attributes.The conditional compilation attributes for tor were redundant since we can do fine using only features.
tokio_unstable
tounexpected_cfgs
.tokio_unstable
inzebrad
.Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.