-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(chain): Drop transactions with unpaid actions #8638
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Jun 24, 2024
upbqdn
removed
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 24, 2024
upbqdn
changed the title
change: Drop transactions with unpaid actions
change(chain): Drop transactions with unpaid actions
Jun 24, 2024
arya2
previously approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thank you.
Co-authored-by: Arya <aryasolhi@gmail.com>
github-actions
bot
added
the
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
label
Jun 24, 2024
arya2
previously approved these changes
Jun 24, 2024
arya2
approved these changes
Jun 25, 2024
arya2
added
A-consensus
Area: Consensus rule updates
and removed
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
extra-reviews
This PR needs at least 2 reviews to merge
labels
Jun 25, 2024
Removed the |
arya2
added
A-rpc
Area: Remote Procedure Call interfaces
A-mempool
Area: Memory pool transactions
and removed
A-consensus
Area: Consensus rule updates
labels
Jun 25, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #8609.
Specifications & References
https://zips.z.cash/zip-0317
Solution
BLOCK_PRODUCTION_UNPAID_ACTION_LIMIT
toBLOCK_UNPAID_ACTION_LIMIT
.BLOCK_UNPAID_ACTION_LIMIT
to 0.Tests
PR Author's Checklist
PR Reviewer's Checklist