Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(chain): Drop transactions with unpaid actions #8638

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jun 24, 2024

Motivation

Close #8609.

Specifications & References

https://zips.z.cash/zip-0317

Solution

  • Rename BLOCK_PRODUCTION_UNPAID_ACTION_LIMIT to BLOCK_UNPAID_ACTION_LIMIT.
  • Set BLOCK_UNPAID_ACTION_LIMIT to 0.
  • Cosmetics & docs along the way.

Tests

  • Adjust existing tests.
  • Add a new one to check if the mempool checks can pass with valid parameters.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn self-assigned this Jun 24, 2024
@upbqdn upbqdn requested a review from a team as a code owner June 24, 2024 14:28
@upbqdn upbqdn requested review from arya2 and removed request for a team June 24, 2024 14:28
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jun 24, 2024
@upbqdn upbqdn removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 24, 2024
@upbqdn upbqdn changed the title change: Drop transactions with unpaid actions change(chain): Drop transactions with unpaid actions Jun 24, 2024
arya2
arya2 previously approved these changes Jun 24, 2024
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you.

CHANGELOG.md Outdated Show resolved Hide resolved
zebra-chain/src/transaction/unmined/zip317.rs Outdated Show resolved Hide resolved
Co-authored-by: Arya <aryasolhi@gmail.com>
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Jun 24, 2024
arya2
arya2 previously approved these changes Jun 24, 2024
@arya2 arya2 added A-consensus Area: Consensus rule updates and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG extra-reviews This PR needs at least 2 reviews to merge labels Jun 25, 2024
@arya2
Copy link
Contributor

arya2 commented Jun 25, 2024

Removed the extra-reviews label because it's not actually a consensus rule change, it only affects the transaction verifier tests for mempool requests. I reviewed it especially thoroughly since it is still sensitive code.

@arya2 arya2 added A-rpc Area: Remote Procedure Call interfaces A-mempool Area: Memory pool transactions and removed A-consensus Area: Consensus rule updates labels Jun 25, 2024
mergify bot added a commit that referenced this pull request Jun 25, 2024
@mergify mergify bot merged commit d1a9004 into main Jun 25, 2024
189 checks passed
@mergify mergify bot deleted the remove-unpaid-action-limit branch June 25, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mempool Area: Memory pool transactions A-rpc Area: Remote Procedure Call interfaces P-Medium ⚡
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Remove unpaid action limit
2 participants