Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(chain): Add an NU6 network upgrade variant #8693

Merged
merged 4 commits into from
Jul 18, 2024
Merged

add(chain): Add an NU6 network upgrade variant #8693

merged 4 commits into from
Jul 18, 2024

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Jul 17, 2024 •
edited
Loading

Motivation

Close #7958.

Solution

  • Add an Nu6 variant to the NetworkUpgrade enum.
  • Update docs.

Tests

  • Fix failing tests.

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@upbqdn upbqdn added A-rust Area: Updates to Rust code NU-6 Network Upgrade: NU6 specific tasks labels Jul 17, 2024
@upbqdn upbqdn self-assigned this Jul 17, 2024
@arya2 arya2 mentioned this pull request Jul 17, 2024
Merged
7 tasks
@upbqdn upbqdn marked this pull request as ready for review July 17, 2024 13:17
@upbqdn upbqdn requested review from a team as code owners July 17, 2024 13:17
@upbqdn upbqdn requested review from oxarbitrage and arya2 and removed request for a team and oxarbitrage July 17, 2024 13:17
arya2
arya2 previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

zebra-chain/src/block/commitment.rs Outdated Show resolved Hide resolved
zebra-chain/src/transaction/arbitrary.rs Outdated Show resolved Hide resolved
zebra-consensus/src/transaction/tests/prop.rs Outdated Show resolved Hide resolved
@upbqdn @arya2
Apply suggestions from code review
f998c55 
Co-authored-by: Arya <aryasolhi@gmail.com>
@mergify mergify bot merged commit f9066ae into main Jul 18, 2024
135 checks passed
@mergify mergify bot deleted the add-nu6-variant branch July 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arya2 arya2 arya2 approved these changes

Assignees

@upbqdn upbqdn

Labels
A-rust Area: Updates to Rust code NU-6 Network Upgrade: NU6 specific tasks P-Medium ⚡
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NU6 network upgrade variant
2 participants
@upbqdn @arya2