Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(network-params): Allow configuring NU6 activation height on Regtest #8700

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

arya2
Copy link
Contributor

@arya2 arya2 commented Jul 18, 2024

Motivation

This is useful for testing changes related to NU6 deployment.

Solution

Adds an argument to Network::new_regtest() and testnet::Parameters::new_regtest() for NU6 activation height.

Tests

This will be tested in #8694.

Follow-up Work

Update the Zebra book (blocked on #8694).

PR Author's Checklist

  • The PR name will make sense to users.
  • The PR provides a CHANGELOG summary.
  • The solution is tested.
  • The documentation is up to date.
  • The PR has a priority label.

PR Reviewer's Checklist

  • The PR Author's checklist is complete.
  • The PR resolves the issue.

@arya2 arya2 added NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG P-Medium ⚡ labels Jul 18, 2024
@arya2 arya2 self-assigned this Jul 18, 2024
@arya2 arya2 requested review from a team as code owners July 18, 2024 22:54
@arya2 arya2 requested review from upbqdn and removed request for a team July 18, 2024 22:54
mergify bot added a commit that referenced this pull request Jul 22, 2024
@mergify mergify bot merged commit 42b298b into main Jul 22, 2024
192 checks passed
@mergify mergify bot deleted the add-nu6-regtest-config branch July 22, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG NU-6 Network Upgrade: NU6 specific tasks P-Low ❄️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants