change(consensus): Refactor block::check::subsidy_is_valid()
#8719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructs, splits them into pre/post NU6 funding streams, and adds them as a field on `testnet::Parameters`
…onversion logic with constraints. Minor refactors
…red Testnets, but that being okay since configured testnet parameters are checked when they're being built
…ams, updates the `miner_fees_are_valid()` and `subsidy_is_valid()` functions to check that the deferred pool contribution is valid and that there are no unclaimed block subsidies after NU6 activation, and adds some TODOs
…too, adds Mainnet/Testnet NU6 activation heights, fixes lints/compilation issue
arya2
force-pushed
the
refactor-block-subsidy-check
branch
from
064d266 to
cb039e3
Compare
…est_funding_stream_values()` to use a configured testnet with the post-NU6 Mainnet funding streams height range
arya2
force-pushed
the
refactor-block-subsidy-check
branch
from
f407928 to
fd76ec5
Compare
… unnecessary checks
arya2
force-pushed
the
refactor-block-subsidy-check
branch
from
fd76ec5 to
ecf2846
Compare
7 tasks
arya2
commented
Jul 25, 2024
Comment on lines
-168
to
-173
| if height < slow_start_interval { | ||
| unreachable!( | ||
| "unsupported block height: callers should handle blocks below {:?}", | ||
| slow_start_interval | ||
| ) | ||
| } else if halving_div.count_ones() != 1 { |
There was a problem hiding this comment.
height < slow_start_interval is checked in num_halvings() (and was checked in halving_divisor() before this change)
halving_div.count_ones() != 1 where halving_div is 1 << num_halvings should always be false if num_halvings <= 2 (and should have always been false before this change since it would return early if 1u64.checked_shl(num_halvings) == None).
|
Closing this for now, it's easier to recreate than to maintain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an optional refactor of the
subsidy_is_valid()function and could include other cleanups following the NU6 consensus rule changes.Depends-On: #8694.
Solution
num_halvings()fnnum_halvings()instead ofhalving_divisor()insubsidy_is_valid()Tests
Zebra has several vectors tests for this function.
PR Author's Checklist
PR Reviewer's Checklist